fontawsome icons don't show underlines to indicate modal/tooltip

[damithc]

v2.9.1

code:

<trigger trigger="click" for="modal:context-target">:fas-info:</trigger> 
<trigger trigger="click" for="modal:context-target">no icon</trigger> 

output:

problem: note how the underline is missing from the first trigger

[hcwong]

Hello Markbind peeps, can I take this?

[ang-zeyu]

Hello Markbind peeps, can I take this?

👍 Don't think anyone's working on this

[ang-zeyu]

Ignore the extra stuff earlier, could just do this with css.

Might check if it works for octicons though

[hcwong]

Hmmm I've changed Tooltip and trigger components: changing the underline style from text-decoration: underline dashed to border bottom: 1px dashed black (for standardization). Is this okay?

[ang-zeyu]

Sounds good; Might wanna try currentColor instead of black to keep the same underline color though

[damithc]

This feature seems to be broken again. See https://nus-cs2113-ay1920s2.github.io/website/admin/participation-dashboard.html

[hcwong]

@damithc is it the A0xxxxx values in the table?

[damithc]

@damithc is it the A0xxxxx values in the table?

Close. It's the ℹ️ icon that comes after the partial matric number. Clicking on it opens a modal, which means there should be a dotted line under it.

[hcwong]

I see, I tried finding the page on https://github.com/nus-cs2113-AY1920S2/website, but cant seem to find it. Is there anywhere I can find it to help debug (cos only the icon seems to be part of trigger, oddly)?

[damithc]

It's in the cs2113 branch. https://github.com/nus-cs2113-AY1920S2/website/blob/cs2113/admin/tp-progress-dashboard-table.mbdf

[hcwong]

Thanks will debug and get back to you on this

[hcwong]

Hey @damithc, just an update from me, this is a regression bug caused by this commit: f215eee.

Also, not sure, but for the 2113 website, I think the student number A018XXXX should be within the <trigger> blocks if its meant to be underlined, unless thats the intended behaviour.

[damithc]

Hey @damithc, just an update from me, this is a regression bug caused by this commit: f215eee.

I see. How to fix?

Also, not sure, but for the 2113 website, I think the student number A018XXXX should be within the <trigger> blocks if its meant to be underlined, unless thats the intended behaviour.

Thanks for the heads up. Only the icon is supposed act as the trigger, so it's all good.

[hcwong]

@openorclose, don't have much context on the commit, but seems like changing the .trigger class in markind's asset/css back to border-bottom: 1px dashed currentColor restores the intended behavior. If this is fine by you, I'll submit the fix.

Also, it seems like the mounted() code in trigger is made redundant by the commit. Should i remove it as well?

[openorclose]

@openorclose, don't have much context on the commit, but seems like changing the .trigger class in markind's asset/css back to border-bottom: 1px dashed currentColor restores the intended behavior. If this is fine by you, I'll submit the fix.

Sure, thanks!

Also, it seems like the mounted() code in trigger is made redundant by the commit. Should i remove it as well?

MarkBind/vue-strap#135 nah there's already a pr to delete triggers and the other unneeded components