Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fontawsome icons don't show underlines to indicate modal/tooltip #1133

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Fix fontawsome icons don't show underlines to indicate modal/tooltip #1133

merged 2 commits into from
Mar 30, 2020

Conversation

hcwong
Copy link
Contributor

@hcwong hcwong commented Mar 18, 2020

What is the purpose of this pull request? (put "X" next to an item, remove the rest)
This pull request restores the intended underline behavior of triggers.

Fixes #995

Proposed commit message: (wrap lines at 72 characters)

Fix trigger underline.

@hcwong
Copy link
Contributor Author

hcwong commented Mar 18, 2020

@openorclose can't seem to tag reviewers lol. can i use this to tag you instead?

yamgent
yamgent requested changes Mar 29, 2020
View reviewed changes
Copy link
Member

@yamgent yamgent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style must also be changed in .trigger-click found in the master branch.

@hcwong
Copy link
Contributor Author

hcwong commented Mar 29, 2020

This style must also be changed in .trigger-click found in the master branch.

Got it, rebased and fixed!

@yamgent yamgent added this to the v2.13.1 milestone Mar 30, 2020
@yamgent yamgent merged commit a9c4d55 into MarkBind:master Mar 30, 2020
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Apr 9, 2020
@Tejas2805
Merge branch 'master' of https://github.com/MarkBind/markbind
9792d68 
* 'master' of https://github.com/MarkBind/markbind: (41 commits)
  Document adding new site content in DG (MarkBind#1153)
  Add relative date feature (MarkBind#908)
  Use <br> to separate lines of code block (MarkBind#1176)
  Parse popovers for footnotes (MarkBind#1155)
  Resolve comments
  Expand test extensions and fix whitespace checks (MarkBind#1156)
  Address comments
  Upgrade js-beautify and provide option to turn it off (MarkBind#1116)
  Normalize inline puml line ending before hashing (MarkBind#1174)
  Update tests (MarkBind#1178)
  Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148)
  Fix bug in Search for UG and DG (MarkBind#1147)
  Add inline puml support (MarkBind#1100)
  Fix hrefs for headings with angular brackets (MarkBind#1089)
  Update tests for 2.13.1 (MarkBind#1169)
  2.13.1
  Update vue-strap version to v2.0.1-markbind.39
  Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133)
  2.13.0
  Update test files
  ...
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
@hcwong
Fix fontawsome icons don't show underlines to indicate modal/tooltip (#…
28d039f 
…1133)
This was referenced Sep 12, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamgent yamgent yamgent approved these changes

@openorclose openorclose openorclose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.13.1
Development

Successfully merging this pull request may close these issues.

fontawsome icons don't show underlines to indicate modal/tooltip
3 participants
@hcwong @yamgent @openorclose