Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to bootstrap-vue 2.5.0 #1085

Merged
merged 4 commits into from
Mar 29, 2020
Merged

Conversation

openorclose
Copy link
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• Enhancement to an existing feature

What is the rationale for this request?

Bootstrap-vue 2.5.0 has much better popovers and tooltips. They allow you to hover over the popover/tooltip and it won't disappear.

What changes did you make? (Give an overview)

Updated bootstrap-vue js and css

Provide some example code that this change will affect:

Is there anything you'd like reviewers to focus on?

Nothing else is broken

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

@ang-zeyu
Copy link
Contributor

ang-zeyu commented Mar 4, 2020

The changelog dosen't seem to have breaking changes either.

The positioning still seems to be off for top/bottom though, as mentioned in #1033 (comment)
positioning

@openorclose
Copy link
Contributor Author

The changelog dosen't seem to have breaking changes either.

The positioning still seems to be off for top/bottom though, as mentioned in #1033 (comment)
positioning

Oh right, let me investigate

package.json Outdated Show resolved Hide resolved
@yamgent
Copy link
Member

yamgent commented Mar 15, 2020

Where did you obtain the min.js from? My copy of bootstrap-vue@2.5.0 does not match yours.

@openorclose
Copy link
Contributor Author

Where did you obtain the min.js from? My copy of bootstrap-vue@2.5.0 does not match yours.

I got it from https://unpkg.com/bootstrap-vue@2.5.0/dist/bootstrap-vue.min.js

@marvinchin
Copy link
Contributor

Where did you obtain the min.js from? My copy of bootstrap-vue@2.5.0 does not match yours.

I got it from https://unpkg.com/bootstrap-vue@2.5.0/dist/bootstrap-vue.min.js

@yamgent is this good to go?

@yamgent yamgent added this to the v2.12.1 milestone Mar 29, 2020
@yamgent yamgent merged commit 4606143 into MarkBind:master Mar 29, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants