Remove OK button from modals #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openorclose
force-pushed
the
remove-modal-ok
branch
from
834cc9c
to
0e56017
Compare
ang-zeyu
reviewed
Mar 21, 2020
|
|
||
| if (!hasFooter && !hasOkTitle) { | ||
| // markbind doesn't show the footer by default | ||
| node.attribs['hide-footer'] = ''; |
There was a problem hiding this comment.
does setting it to true erase the ="" portion in hide-footer=""? might be nice if so, same for ok-only
There was a problem hiding this comment.
Nope, i just get this
| consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. | ||
| Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. | ||
| </modal> | ||
|
|
||
| ``` | ||
| </span> | ||
| <span id="output"> |
There was a problem hiding this comment.
should ok-text be ok-title instead? ( the props table )
There was a problem hiding this comment.
Should be fine as ok-text. since it's not really a title of anything.
There was a problem hiding this comment.
Remove the redundant OK button from modals, only show it if the author specifies
ok-title.
Ahh ok, thought the attribute from the user standpoint here was ok-title
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Mar 23, 2020
* 'master' of https://github.com/MarkBind/markbind: Update test files (MarkBind#1138) Remove OK button from modals (MarkBind#1134) Add start from line number functionality to code blocks (MarkBind#1115) Allow special tags to be self-closing (MarkBind#1101) Simplify baseUrl resolving process (MarkBind#1087) Remove redundant file writing (MarkBind#1090) Bump acorn from 5.7.3 to 5.7.4 (MarkBind#1121) Bump acorn from 7.1.0 to 7.1.1 in /src/lib/markbind (MarkBind#1120) Unify markdown-it parser variants (MarkBind#1056) Remove dynamic include feature (MarkBind#1037) Fix flex shrink not applying in content wrapper (MarkBind#1135) Escape Nunjucks for special tags (MarkBind#1049) Update documentation on icon slot for boxes (MarkBind#1123)
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Mar 23, 2020
…x-pageNav * 'master' of https://github.com/MarkBind/markbind: Update test files (MarkBind#1138) Remove OK button from modals (MarkBind#1134) Add start from line number functionality to code blocks (MarkBind#1115) Allow special tags to be self-closing (MarkBind#1101) Simplify baseUrl resolving process (MarkBind#1087) Remove redundant file writing (MarkBind#1090) Bump acorn from 5.7.3 to 5.7.4 (MarkBind#1121) Bump acorn from 7.1.0 to 7.1.1 in /src/lib/markbind (MarkBind#1120) Unify markdown-it parser variants (MarkBind#1056) Remove dynamic include feature (MarkBind#1037) Fix flex shrink not applying in content wrapper (MarkBind#1135) Escape Nunjucks for special tags (MarkBind#1049) Update documentation on icon slot for boxes (MarkBind#1123) Convert code in boxes to code block (MarkBind#1086)
marvinchin
pushed a commit
that referenced
this pull request
Apr 10, 2020
Let's remove the redundant OK button from modals, and only show it if the `ok-title` attribute is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
Fixes #1126
What is the rationale for this request?
Remove the redundant OK button from modals, only show it if the author specifies
ok-title.What changes did you make? (Give an overview)
If there is no
ok-titleattribute, and there is no footer slot, hide the footer.Is there anything you'd like reviewers to focus on?
Testing instructions:
Added a test and a docs example to show the case where
ok-textis set.Proposed commit message: (wrap lines at 72 characters)