Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variables documentation #1203

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

ang-zeyu
Copy link
Contributor

@ang-zeyu ang-zeyu commented Apr 16, 2020

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [x] Documentation update for #1193 and some reformatting for variable documentation

Proposed commit message: (wrap lines at 72 characters)
Update variable documentation

The limitation of variables not being able to contain incomplete or
malformed xml has been patched.
Some areas of the variable documentation can also be formatted with
newly introduced features to be more visually appealing.

Let’s update the user guide to reflect the patch, and reformat some
areas of the variable documentation.

@damithc
Copy link
Contributor

damithc commented Apr 16, 2020

Do we have an example of using ill-formed xml as a variable? Some might assume the value needs to be well-formed even if it was never mentioned.

@ang-zeyu
Copy link
Contributor Author

Do we have an example of using ill-formed xml as a variable? Some might assume the value needs to be well-formed even if it was never mentioned.

ok I see the point. I didn't document this as I felt that it should be the expected behaviour.
Noticed some other areas the variables docs can be tidied up in as well. Will expand the scope of this.

@ang-zeyu ang-zeyu force-pushed the update-variable-docs branch 3 times, most recently from fa586d4 to ec48c07 Compare April 17, 2020 10:28
@ang-zeyu ang-zeyu changed the title Remove variable tags limitation from user guide Update variables documentation Apr 17, 2020
@le0tan le0tan added the pr.DocsUpdate 📃 Pure changes to the documentation, such as typo, restructuring, etc label Apr 22, 2020
The limitation of variables not being able to contain incomplete or
malformed xml has been patched.
Some areas of the variable documentation can also be formatted with
newly introduced features to be more visually appealing.

Let’s update the user guide to reflect the patch, and reformat some
areas of the variable documentation.
@ang-zeyu ang-zeyu merged commit af495cf into MarkBind:master Jun 7, 2020
@ang-zeyu ang-zeyu added this to the v2.15.0 milestone Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr.DocsUpdate 📃 Pure changes to the documentation, such as typo, restructuring, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants