Fix several b-modal selector names #1218
Conversation
The bootstrap vue migration causes modal elements to be transformed into b-modal. Let’s change the leftover selector names to match the new name.
|
Not very familiar, so I need to make some clarifications before I approve. Basically, #1033 migrated modals to b-modals, but there were some parts of the code, namely the files you edited, that still used the previous name? So you finished up the leftovers? |
|
it was missed out in #1033, and only surfaced now. Could double check with @openorclose if there's a reason it wasn't changed though (unlikely) |
There was a problem hiding this comment.
it was missed out in #1033, and only surfaced now. Could double check with @openorclose if there's a reason it wasn't changed though (unlikely)
Should be unlikely, LGTM
No reason, I missed it out. Thanks for the fix! |
|
ok will merge it in then, thanks for looking through it @nbriannl @openorclose! |
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
Fixes #1217
What changes did you make? (Give an overview)
Change leftover
'modal'selectors from the bootstrap vue migration to'b-modal'Testing instructions:
npm run testshould passProposed commit message: (wrap lines at 72 characters)
Fix several b-modal selector names
The bootstrap vue migration causes modal elements to be transformed into
b-modal.
Let’s change the leftover selector names to match the new name.