Refactor parser into a page instance variable #1226
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Other, please explain: small code refactor, originally part of #1189 ( decided to extract this out as well so less changes are observed over there )
What is the rationale for this request?
We use
parser
(markbinder
) in several places inPage.js
now. Passing it around as a parameter isn't really ideal (#1225), hence, let's make it an instance variable instead.What changes did you make? (Give an overview)
markbinder
variable name toparser
resolveDependency
promises accordingly.includedFiles
collection inresolveDependency
( we can just collect it once inpage.generate()
now, since there's only one parser )Is there anything you'd like reviewers to focus on?
na
Testing instructions:
npm run test
should passProposed commit message: (wrap lines at 72 characters)
Refactor parser into a page instance variable