-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log website URL upon deployment #1329
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e644603
[wip] add git wrapper
19cbd5f
implement get deploy url
KendrickAng 5657f3e
restructure Site/index.js, fix lint errors
KendrickAng e3ea592
Merge branch 'master' into feature/MB-844
KendrickAng 024868c
add base dir when initializing simple-git
KendrickAng 6e249cb
[fix] No such file or directory error when initializing simple-git in…
dccad64
add package-lock.json
KendrickAng 053ee1b
update code from pr comments
KendrickAng ce58556
update package-lock.json
KendrickAng 431613a
make changes from comments
KendrickAng d2f7c32
update package-lock.json
KendrickAng ac0066f
update package-lock.json
KendrickAng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/** | ||
* Contains methods using simple-git to perform commands relating to git. | ||
*/ | ||
module.exports = { | ||
/** | ||
* Returns the contents of a remote file, undefined if an error was encountered. | ||
* See: https://git-scm.com/docs/git-cat-file for accepted values for each input. | ||
*/ | ||
async getRemoteBranchFile(simpleGit, type, remote, branch, fileName) { | ||
try { | ||
const catFileTarget = `${remote}/${branch}:${fileName}`; | ||
return await simpleGit.catFile([type, catFileTarget]); | ||
} catch (e) { | ||
return undefined; | ||
} | ||
}, | ||
/** | ||
* Returns the contents of a remote url (https or ssh), undefined if an error was encountered. | ||
*/ | ||
async getRemoteUrl(simpleGit, remote) { | ||
try { | ||
return await simpleGit.remote(['get-url', remote]); | ||
} catch (e) { | ||
return undefined; | ||
} | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this mock still necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ang-zeyu otherwise, there would be tons of warnings
warn: message=fatal: Not a valid object name origin/gh-pages:CNAME
thrown in the test for deployment inSite.test.js
.