Implement Disqus plugin #1449
Merged
Implement Disqus plugin #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ang-zeyu Hi Zeyu, this PR is ready for your review :-) if everything looks fine, I will proceed to update the test. |
ang-zeyu
reviewed
Jan 18, 2021
|
@ang-zeyu The PR is ready for your review :-). I've made the changes you suggested. I've also ensured that the redirecting of the path are handled accordingly. Although i'm not sure if there might be any edge cases that I missed out (hopefully not). |
ang-zeyu
reviewed
Jan 21, 2021
wxwxwxwx9
commented
Jan 23, 2021
|
|
||
| <box type="tip"> | ||
|
|
||
| It may be a good idea to create a [layout]({{ baseUrl }}/userGuide/tweakingThePageStructure.html#layouts) with `<disqus/>` in it, so that you won't have to repeat it on every page. |
There was a problem hiding this comment.
{{ baseUrl }}/userGuide/tweakingThePageStructure.html#layouts
I specified it as .html currently as our .md to .html conversion currently can't handle links with #.
I will make a PR to update the implementation and change this to .md afterwards :-)
ang-zeyu
reviewed
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This PR resolves #481.
Overview of changes:
Setup Disqus plugin with lazy loading using IntersectionObserver API.
Anything you'd like to highlight / discuss:
Testing instructions:
Add
<disqus/>to any page andmarkbind serve.You should be able to see the disqus comments section (it should load only when you scroll near it).
Proposed commit message: (wrap lines at 72 characters)
Implement Disqus plugin.
Users may want to allow readers to comment on content in the website.
This can be an important feature for educational websites as it enables
better student interaction.
Let's integrate Disqus into MarkBind to enable this commenting feature.
Checklist: ☑️