Lazy serve: Fix improper handling of incomplete active urls #1532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug reported and acknowledged in #1522 (comment).
Incomplete urls are defaulted to
index.md
in the path specified, e.g.hostName/userGuide
serveshostName/userGuide/index
, though the request URL is still referring tohostName/userGuide
. This results ingetActiveUrls
returning just/userGuide
, which will be stored asuserGuide
to the current opened pages list, and thus any file change to the actual fileuserGuide/index
can not be detected and rebuilt accordingly.Overview of changes:
live-server
before passing it to MarkBind's opened pages list, to appendindex
on every incomplete urls.Anything you'd like to highlight / discuss:
Testing instructions:
127.0.0.1:8080
(without/index
)index.md
index
.Proposed commit message: (wrap lines at 72 characters)
Lazy serve: Fix improper handling of incomplete active urls
Checklist: ☑️