-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate some component attributes #1722
Deprecate some component attributes #1722
Conversation
I just ran the tests again locally on master and was able to pass all. |
Thanks @tlylt , that works! Have updated the issue description :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes @jovyntls :)
LGTM 馃憤
What is the purpose of this pull request?
Fixes #1504
Overview of changes:
Anything you'd like to highlight / discuss:
The
_warnDeprecatedAttributes
function was removed as well.Also, I notice that the master branch doesn't seem to be passing all tests onnpm run test
(not as a result of this PR), but this can be fixed withnpm run updatetest
.Should commit the files generated by
npm run updatetest
here as well? The non-updated tests are not a result of this PR so I'm not sure if it should be in the scope of this PR. 馃槄Proposed commit message: (wrap lines at 72 characters)
Checklist: 鈽戯笍