Fix extra newline in convert feature #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahtanjz
reviewed
Feb 2, 2022
packages/core/src/Site/index.js
Outdated
| @@ -436,14 +436,14 @@ class Site { | |||
| .filter(addressablePage => !addressablePage.src.startsWith('_')) | |||
| .forEach((page) => { | |||
| const addressablePagePath = path.join(this.rootPath, page.src); | |||
| const relativePagePathWithoutExt = fsUtil.removeExtension( | |||
| const relativePagePathWithoutExt = fsUtil.removeExtensionPosix( | |||
There was a problem hiding this comment.
Try to rebase to master so this PR doesn't overwrite the changes that has already been merged.
ang-zeyu
approved these changes
Feb 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes #1726
Closes #1727
Overview of changes:
This was caused by the extra newline created at the end of buildSiteNav() in the core/site dir. I simply added a trimEnd() to fix the issue.
Anything you'd like to highlight / discuss:
Testing instructions:
Run
markbind init -converton a test repo and see that there is no more new line before the closing tag.When running tests, the Home.html in
test_navigation_convertshould not contain any unnecessary spaces in the navigation component.Proposed commit message: (wrap lines at 72 characters)
Fixed convert command generating extra newline
Checklist: ☑️