Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump font-awesome from 5.14.0 to 5.15.4 #1822

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

ryoarmanda
Copy link
Contributor

@ryoarmanda ryoarmanda commented Mar 11, 2022

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain: Dependency update

Related to #1793 , dependency bump for setting up #1421

Overview of changes:
Bump font awesome from 5.14.0 to 5.15.4

Anything you'd like to highlight / discuss:
Changelog: https://github.com/FortAwesome/Font-Awesome/blob/master/UPGRADING.md
Only changes are removed Adobe and Tripadvisor icons, don't think it's applicable to us.

Testing instructions:
N/A

Proposed commit message: (wrap lines at 72 characters)
Bump font-awesome from 5.14.0 to 5.15.4


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@ryoarmanda ryoarmanda closed this Mar 11, 2022
@ryoarmanda ryoarmanda reopened this Mar 11, 2022
Copy link
Contributor

@jonahtanjz jonahtanjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonahtanjz jonahtanjz added this to the 4.0 milestone Mar 11, 2022
@jonahtanjz jonahtanjz merged commit 6819367 into MarkBind:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants