Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pop-up docs #1832

Merged
merged 8 commits into from
Mar 18, 2022
Merged

Update pop-up docs #1832

merged 8 commits into from
Mar 18, 2022

Conversation

jovyntls
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:

Overview of changes:

Anything you'd like to highlight / discuss:
N/A

Testing instructions:
markbind serve on the docs

Proposed commit message: (wrap lines at 72 characters)

Update docs for pop-ups

Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

ryoarmanda
ryoarmanda approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@ryoarmanda ryoarmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryoarmanda ryoarmanda added this to the 4.0 milestone Mar 17, 2022
@ryoarmanda ryoarmanda merged commit 13f1f87 into MarkBind:master Mar 18, 2022
ryoarmanda pushed a commit to ryoarmanda/markbind that referenced this pull request Apr 4, 2022
@jovyntls @ryoarmanda
Update docs for pop-ups (MarkBind#1832)
3bb911a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryoarmanda ryoarmanda ryoarmanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jovyntls @ryoarmanda