Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump babel-jest from 26.1.0 to 27.5.1 #1864

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

ryoarmanda
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain: Dependency update

Related to #1421. Due to dependency hoisting by lerna makes installing ts-jest not possible. The reason why is that npm thought we use babel-jest (we use it tin vue-components) to satisfy the optional peer dependency for ts-jest, but the version is lower than required, and thus there is a resolution conflict.

Bumping babel-jest to the satisfiable version fixes this and opens the way to installing ts-jest properly.

Overview of changes:

Anything you'd like to highlight / discuss:
N/A

Testing instructions:
N/A

Proposed commit message: (wrap lines at 72 characters)
Bump babel-jest from 26.1.0 to 27.5.1


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@jonahtanjz jonahtanjz requested a review from tlylt March 30, 2022 15:22
Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahtanjz
Copy link
Contributor

You can try to merge this PR @tlylt :)

@tlylt tlylt merged commit 164ffd7 into MarkBind:master Apr 1, 2022
@tlylt tlylt added this to the 4.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants