Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nodejs to v14 #1920

Merged
merged 2 commits into from
May 11, 2022
Merged

Upgrade nodejs to v14 #1920

merged 2 commits into from
May 11, 2022

Conversation

tlylt
Copy link
Contributor

@tlylt tlylt commented May 3, 2022

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:

Overview of changes:
Fixes #1862

Update CI scripts and documentation mention of the node.js version to 14

Anything you'd like to highlight / discuss:

  • Will likely need a senior dev to update the netlify build script to use node.js 14 if not done already.
  • I have this error when using node v14.15, which does not seem to work with the required packages after typescript migration. I think it is not critical as I am still able to run all the code normally, but wonder if we should specify this condition in our DG
    • image
  • Any other places that I may have missed

Testing instructions:
I have been using nodejs v14 for quite a while locally and doesn't seem to have any issues, but feel free to test it if possible.

Proposed commit message: (wrap lines at 72 characters)
Upgrade nodejs to v14


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Copy link
Contributor

@jonahtanjz jonahtanjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tlylt

I have this error when using node v14.15, which does not seem to work with the required packages after typescript migration. I think it is not critical as I am still able to run all the code normally, but wonder if we should specify this condition in our DG

Seems fine to me as well. Maybe can get @ryoarmanda to double check on this?

Will likely need a senior dev to update the netlify build script to use node.js 14 if not done already.

Will need @ang-zeyu's assistance on this :)

@ryoarmanda
Copy link
Contributor

ryoarmanda commented May 9, 2022

I have this error when using node v14.15, which does not seem to work with the required packages after typescript migration.

Looks like the error might be resolved if your local node version is upgraded to a higher v14 version. As noted in the image, the packages support Node v14 among other versions (they also keep support for Node v12 too), but with a lower bound of 14.17.0. Your local node version is 14.15.1, which is below that. You can try upgrading it to a higher v14 version if need be, or jump to v16 LTS if you'd like.


Notwithstanding the above, I think the move to v14 should be done as v12 has reached end of life on 30 April.

@tlylt
Copy link
Contributor Author

tlylt commented May 9, 2022

Your local node version is 14.15.1, which is below that. You can try upgrading it to a higher v14 version if need be, or jump to v16 LTS if you'd like.

I see. Do you think it will be good to mention in our DG that we require 14.17.0 and above? Currently, it will only say v14 and above, which is slightly misleading. (I assume that this is fine for end-users as long as they have v14 so need no specify for UG)

@ryoarmanda
Copy link
Contributor

I see. Do you think it will be good to mention in our DG that we require 14.17.0 and above? Currently, it will only say v14 and above, which is slightly misleading. (I assume that this is fine for end-users as long as they have v14 so need no specify for UG)

Yeah, let's do that 👍

Copy link
Contributor

@jonahtanjz jonahtanjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'll leave the merging to @ang-zeyu once the netlify build script has been updated :)

@ang-zeyu ang-zeyu added this to the 4.0 milestone May 11, 2022
@ang-zeyu ang-zeyu merged commit 3147259 into MarkBind:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade node.js to v14
4 participants