-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade nodejs to v14 #1920
Upgrade nodejs to v14 #1920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tlylt
I have this error when using node v14.15, which does not seem to work with the required packages after typescript migration. I think it is not critical as I am still able to run all the code normally, but wonder if we should specify this condition in our DG
Seems fine to me as well. Maybe can get @ryoarmanda to double check on this?
Will likely need a senior dev to update the netlify build script to use node.js 14 if not done already.
Will need @ang-zeyu's assistance on this :)
Looks like the error might be resolved if your local node version is upgraded to a higher v14 version. As noted in the image, the packages support Node v14 among other versions (they also keep support for Node v12 too), but with a lower bound of Notwithstanding the above, I think the move to v14 should be done as v12 has reached end of life on 30 April. |
I see. Do you think it will be good to mention in our DG that we require |
Yeah, let's do that 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'll leave the merging to @ang-zeyu once the netlify build script has been updated :)
What is the purpose of this pull request?
Overview of changes:
Fixes #1862
Update CI scripts and documentation mention of the node.js version to 14
Anything you'd like to highlight / discuss:
Testing instructions:
I have been using nodejs v14 for quite a while locally and doesn't seem to have any issues, but feel free to test it if possible.
Proposed commit message: (wrap lines at 72 characters)
Upgrade nodejs to v14
Checklist: ☑️