Exclude node_modules from copying and page rendering in default site.json #1925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #1844
Anything you'd like to highlight / discuss:
nil
Testing instructions:
markbind init
site.json
npm init -y
and thennpm install happy-birthday
markbind serve
ormarkbind build
Proposed commit message: (wrap lines at 72 characters)
Exclude node_modules from page rendering in default site.json
If there are node modules installed along with MarkBind, the
README.md files within these folders will be processed due to
our default glob pattern in
site.json
, and they will be copiedover to the production site.
The users will typically want to avoid the above situation, but
they may not be familiar with MarkBind configurations early on
and can be troubled by this problem.
Let's exclude node_modules from copying over to the
production site and add them into
pagesExclude
to preventany processing, by default.
This change will not affect users negatively but provides a
sensible default to deal with node_modules.
Checklist: ☑️