Update test_site to test file ignore #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlylt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #792
On second thought, putting up this PR to make it clear that we have a few files in
test_sitethat are used to test the file ignore functionality.Anything you'd like to highlight/discuss:
The alternative is to remove the test utility files altogether, to avoid confusing future developers.
Testing instructions:
nil, existing test cases cover the update.
Proposed commit message: (wrap lines at 72 characters)
Update test_site to test file ignore
test_sitecontains a few files that previously served as testing utils.Let's update the folder/file names and add comments to indicate
that these files are no longer invoked and only serve as a way to
test the file ignore functionality of the
site.jsonfile.This will prevent future developers from being confused about
the purpose of those test utility files in
test_site.Checklist: ☑️