Migrate Site/Page config classes to typescript #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlylt
reviewed
Sep 3, 2022
jonahtanjz
approved these changes
Sep 9, 2022
ang-zeyu
force-pushed
the
migrate-config-classes
branch
from
5e44b86
to
a46e719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Tackles part of #1913
Overview of changes:
Site/PageConfigclasses to typescriptThis should enable migration of the rest of the
src/htmlfolder more smoothly/independentlyAnything you'd like to highlight/discuss:
See commit message
Testing instructions:
na
Proposed commit message: (wrap lines at 72 characters)
NA (in the commits themselves), let's do a rebase here to preserve the file rename
Checklist: ☑️