Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate lib/nunjucks-extensions to TypeScript #2321

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

yucheng11122017
Copy link
Contributor

@yucheng11122017 yucheng11122017 commented Jul 6, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Part of #1913

Overview of changes:
Migrates files (nunjucks-date.test.js and set-external.test.js) in lib/nunjucks-extensions to TS

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Migrate lib/nunjucks-extensions to TypeScript


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@yucheng11122017 yucheng11122017 marked this pull request as ready for review July 7, 2023 14:00
@yucheng11122017 yucheng11122017 changed the title [WIP] Migrate lib/nunjucks-extensions to TypeScript Migrate lib/nunjucks-extensions to TypeScript Jul 7, 2023
@tlylt tlylt added this to the v5.0.0 milestone Jul 12, 2023
@tlylt tlylt merged commit ea73e18 into MarkBind:master Jul 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants