Fix bs-modal css variables #2353 #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I completely understand that filling out the PR description can feel like a chore, but it's actually quite valuable for the reviewers. Your effort will go a long way in ensuring a smooth and efficient review process. Thank you GPT for providing the above 🤣 |
Codecov Report
@@ Coverage Diff @@
## master #2354 +/- ##
=======================================
Coverage 44.82% 44.82%
=======================================
Files 122 122
Lines 5133 5133
Branches 1082 1082
=======================================
Hits 2301 2301
Misses 2513 2513
Partials 319 319
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Please add in
To aid review plz. (after you have implemented the changes discussed in the issue) |
tlylt
approved these changes
Aug 24, 2023
|
@all-contributors please add @jmestxr for code, doc |
|
I've put up a pull request to add @jmestxr! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes: Fixes #2353
.modalclass tovue-final-modalcomponentdisplay=blockfor the.modalclass to disable display toggling provided by bootstrapBefore:
When using a (non-default) bootswatch theme, bs-modal css variables for modal component are not found, resulting in it not being styled properly:
bootswatch theme used: 'sketchy'
After:
bs-modal CSS variables now registered in modal component:
Anything you'd like to highlight/discuss:
Testing instructions:
site.jsoninpackages/cli/test/functional/test_siteto add any non-default bootswatch theme (see https://markbind.org/userGuide/themes.html)packages/cli/test/functional/test_siteand runmarkbind serve -dtest_site/testModals.htmlin browser and ensure that all modals are rendered correctly in terms of stylingProposed commit message: (wrap lines at 72 characters)
Register bs-modal css variables in Modal component
Checklist: ☑️