Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement modal scrolling using Bootstrap's .modal-dialog-scrollable #2363

Merged
merged 3 commits into from Aug 28, 2023

Conversation

jmestxr
Copy link
Contributor

@jmestxr jmestxr commented Aug 28, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Resolves #2362

Reimplement PR #2322

Overview of changes:

We can directly use Bootstrap's provided class .modal-dialog-scrollable (see https://getbootstrap.com/docs/5.1/components/modal/#scrolling-long-content), rather than the cumbersome way of adding custom styles (max-height and overflow-auto) previously done in PR #2322.

Anything you'd like to highlight/discuss:

Testing instructions:
Run npm test to ensure snapshot tests are updated, and

  1. cd into packages/cli/test/functional/test_site and run markbind serve -d
  2. navigate to test_site/testModals.html in browser and test out Trigger for modal that should overflow

Proposed commit message: (wrap lines at 72 characters)
Reimplement scrolling using .modal-dialog-scrollable


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2363 (905ee32) into master (ebe9b9b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2363   +/-   ##
=======================================
  Coverage   45.11%   45.11%           
=======================================
  Files         123      123           
  Lines        5165     5165           
  Branches     1086     1086           
=======================================
  Hits         2330     2330           
  Misses       2516     2516           
  Partials      319      319           
Files Changed Coverage Δ
packages/vue-components/src/Modal.vue 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlylt tlylt added this to the v5.0.3 milestone Aug 28, 2023
@tlylt tlylt merged commit 34493cc into MarkBind:master Aug 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement modal scrolling using Bootstrap's .modal-dialog-scrollable
2 participants