Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add horizontal spacing between the icon and text in the custom icon list #2352 #2375

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Add horizontal spacing between the icon and text in the custom icon list #2352 #2375

merged 7 commits into from
Mar 12, 2024

Commits on Oct 28, 2023

  1. Add i-spacing attribute to CustomListIconProcessor.ts 

    - Allow users to modify icon's size, width, height, and class for customizing icon attributes while also providing the option to adjust spacing between the icon and text for enhanced user experience.

- Add "i-spacing" attribute to ICON_ATTRIBUTES and interface IconAttributes in CustomListIconProcessor.ts.

- Implement logic to check whether the user has defined the i-spacing attribute or not.

- Update createIconSpan function to incorporate i-spacing attribute.

- Update getIconAttributes function to retrieve i-spacing attribute.

- This consolidation of attributes maintains code consistency and cleanliness.

- Refer issues: MarkBind#2352, MarkBind#2316.
    @Ashleeey1224
    Ashleeey1224 committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    0c854da View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge branch 'master' of https://github.com/MarkBind/markbind into As… 

    …hleeey1224/MarkBind#2352-i-spacing-feature
    @yucheng11122017
    yucheng11122017 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    9b28854 View commit details
    Browse the repository at this point in the history

  2. remove unecessary comments

    @yucheng11122017
    yucheng11122017 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    e0690fe View commit details
    Browse the repository at this point in the history

  3. add documentation for i-spacing

    @yucheng11122017
    yucheng11122017 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    e6c2d85 View commit details
    Browse the repository at this point in the history

  4. add functional test cases

    @yucheng11122017
    yucheng11122017 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b7852ea View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Merge branch 'master' of https://github.com/MarkBind/markbind into Ma… 

    …rkBind#2352-i-spacing-feature
    @yucheng11122017
    yucheng11122017 committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    5506dbb View commit details
    Browse the repository at this point in the history

  2. rename iSpacing to iconSpacing

    @yucheng11122017
    yucheng11122017 committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    624d093 View commit details
    Browse the repository at this point in the history