Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove unused CSS for seamless panel styling #2407

Merged
merged 1 commit into from Feb 7, 2024

Conversation

kaixin-hc
Copy link
Contributor

@kaixin-hc kaixin-hc commented Feb 7, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Fixes #2324

Overview of changes:
Remove the css related to card-seamless

Here is a recording of the behaviour of seamless panel after the changes, which is identical to the current behaviour
https://github.com/MarkBind/markbind/assets/59471320/eb53b809-2f2e-4de6-ad97-554839aed9d3

Anything you'd like to highlight/discuss:

Testing instructions:

markbind serve -d on markbind/docs, navigate to panel, see that behaviour is unchanged

Proposed commit message: (wrap lines at 72 characters)
Chore: Remove unused CSS for seamless panel


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67ae4b1) 48.87% compared to head (f96a89e) 48.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2407   +/-   ##
=======================================
  Coverage   48.87%   48.87%           
=======================================
  Files         124      124           
  Lines        5238     5238           
  Branches     1109     1109           
=======================================
  Hits         2560     2560           
  Misses       2371     2371           
  Partials      307      307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yucheng11122017 yucheng11122017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kaixin-hc kaixin-hc merged commit a265c73 into MarkBind:master Feb 7, 2024
8 checks passed
@kaixin-hc kaixin-hc deleted the remove-unused-css branch February 7, 2024 14:12
@yucheng11122017 yucheng11122017 added the r.Patch Version resolver: increment by 0.0.1 label Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r.Patch Version resolver: increment by 0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.card-seamless CSS in NestedPanel does not target any element
2 participants