Migrate core/index.js to Typescript #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2482 +/- ##
=======================================
Coverage 51.11% 51.11%
=======================================
Files 124 124
Lines 5355 5355
Branches 1152 1152
=======================================
Hits 2737 2737
Misses 2328 2328
Partials 290 290 ☔ View full report in Codecov by Sentry. |
|
@yiwen101 - please revert the merge commit 😅 |
Adapt code/index to Typescript
sorry, I must have accidentally hit "update with merge" someday😅. |
|
LGTM! |
itsyme
approved these changes
Apr 4, 2024
|
@itsyme Each PR must have a SEMVER impact label, please remember to label the PR properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Working on #1913; quite trivial changes.
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Migrate core/index.js to Typescript
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):