Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Document making the text icon bold with t-class in lists #2534

Merged
merged 2 commits into from Apr 28, 2024

Conversation

kaixin-hc
Copy link
Contributor

@kaixin-hc kaixin-hc commented Apr 28, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Addresses #2489

Overview of changes:
Adds an example of bold text to the customising text-icon for bold text section

Anything you'd like to highlight/discuss:
I don't think the look of it is great but I think this makes it visible for users.
Screenshot 2024-04-28 at 11 14 31 AM

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Document bootstrap classes with t-class in lists


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Copy link
Contributor

@EltonGohJH EltonGohJH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with the change.
I think I could not tell that the text is bolded if I am not looking for it.

Are there any areas where the doc mention that you can use fw-bold to bold? If not we should mention it somewhere on the docs. Wdyt

@kaixin-hc
Copy link
Contributor Author

You make a good point - I've added a tooltip that signposts to look at the bootstrap documentation, and also added italics to the one that is below so that the text having difference is more expected. See below picture


Screenshot 2024-04-28 at 9 15 57 PM

Copy link
Contributor

@EltonGohJH EltonGohJH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change!

@kaixin-hc kaixin-hc merged commit aee7efc into MarkBind:master Apr 28, 2024
8 checks passed
Copy link

@kaixin-hc Each PR must have a SEMVER impact label, please remember to label the PR properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants