Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to milestone & remove it from project management docs #2537

Merged
merged 2 commits into from Apr 29, 2024

Conversation

kaixin-hc
Copy link
Contributor

@kaixin-hc kaixin-hc commented Apr 28, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Resolves #2142

Overview of changes:
Remove references to milestone and steps relating to milestone from our DG. Also added a short tip to the bottom about why this was removed so future developers understand our reasoning.

Anything you'd like to highlight/discuss:

Testing instructions:
Go to the project management page in netlify and read through it.

Proposed commit message: (wrap lines at 72 characters)
Remove milestones from our project workflow docs


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Copy link
Contributor

@yucheng11122017 yucheng11122017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except small nit! Thank you:)

docs/devGuide/projectManagement.md Outdated Show resolved Hide resolved
Co-authored-by: Chan Yu Cheng <77204346+yucheng11122017@users.noreply.github.com>
@kaixin-hc kaixin-hc merged commit d2dc58e into MarkBind:master Apr 29, 2024
8 checks passed
Copy link

@kaixin-hc Each PR must have a SEMVER impact label, please remember to label the PR properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do we use milestones in PRs (and releases)?
2 participants