Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on netlify config when migrating Node.js #2554

Merged
merged 1 commit into from
May 27, 2024

Conversation

tlylt
Copy link
Contributor

@tlylt tlylt commented May 18, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Fixes #2246

Anything you'd like to highlight/discuss:
nil

Testing instructions:
https://deploy-preview-2554--markbind-master.netlify.app/devguide/development/migratingnodejs

Proposed commit message: (wrap lines at 72 characters)
Add note on netlify config when migrating Node.js


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Copy link
Contributor

@ong6 ong6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tlylt tlylt merged commit 2c82764 into MarkBind:master May 27, 2024
10 checks passed
Copy link

@tlylt Each PR must have a SEMVER impact label, please remember to label the PR properly.

@tlylt tlylt deleted the update-dev-docs-nodejs branch May 27, 2024 04:01
@tlylt tlylt added the r.Patch Version resolver: increment by 0.0.1 label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r.Patch Version resolver: increment by 0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note on netlify config when migrating Node.js
2 participants