Site: Initialize baseUrl before user variables #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The baseUrl variable is only initialized after all user variables have been processed. If the content of the user variables refer to baseUrl, baseUrl will be evaluated as empty because it is not initialized yet. Let's rearrange the order of variable initialization such that baseUrl is initialized first. That way, user variables that reference it will not have an empty value since it is initialized by the time the user variables are processed.
acjh
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
Fixes #261.
What is the rationale for this request?
If a user variable refers to
baseUrl, the string is empty instead of the actualbaseUrl.What changes did you make? (Give an overview)
Shifted the order of the variable initialization such that baseUrl is initialized first. Thanks to @rachx for the fix suggestion.
Provide some example code that this change will affect:
https://github.com/yamgent/markbind-problems/tree/master/issue_261
Is there anything you'd like reviewers to focus on?
NIL
Testing instructions:
issue_261.markbind serve.a. In the buggy version, the second line will render as
The baseUrl that we are using is .(i.e.baseUrldoes not render properly).