Disable decamelize for anchor generation #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for compatibility with GFMD
|
A vue-strap side PR is needed to complement this PR as well. |
|
@yamgent vue-strap side PR created: MarkBind/vue-strap#95. |
yamgent
pushed a commit
to MarkBind/vue-strap
that referenced
this pull request
Feb 8, 2019
In MarkBind/markbind#667, we disabled decamelization for anchor headings to retain compatibility with GFMD. Let's disable decamelization in vue-strap as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
Resolves #653.
What is the rationale for this request?
Currently, anchors generated by MarkBind are "decamelized", with camelCased words being split: MarkBind becomes
mark-bind. This breaks compatibility with GFMD.What changes did you make? (Give an overview)
I modified the
slugifyoption passed tomarkdown-it-anchorto always callslugify()withdecamelize: false.Provide some example code that this change will affect:
# Headings with camelCase or PascalCaseTesting instructions:
# camelCase and PascalCaseshould have an anchor of#camelcase-and-pascalcase.