Fix Travis deploy repo regex to only match .git at end #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- match .git only at end of string - match periods in repository name
nicholaschuayunzhi
approved these changes
Feb 21, 2019
yamgent
approved these changes
Feb 21, 2019
yamgent
changed the title
yamgent
pushed a commit
to yamgent/markbind
that referenced
this pull request
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
Resolves an issue discovered during a test of #701.
What is the rationale for this request?
The regex we use for matching GitHub repo slugs in Travis is incorrect and may make Travis push to the wrong repository. For example, our regex would incorrectly match
https://github.com/MarkBind/markbind.github.io.gitasMarkBind/markbind.git:What changes did you make? (Give an overview)
I fixed the regex to only match
.gitat the end ($) and to match periods in the repository name.Testing instructions:
repoinsite.jsonwith a.gitin the name. It should not match the.gitin the name, only the end.Eg.
https://github.com/MarkBind/markbind.github.io.gitshould match asMarkBind/markbind.github.io.git.