Add docs for popover and tooltip hoverable attr #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openorclose
force-pushed
the
doc-popover-hoverable
branch
from
7a32cc5
to
8181102
Compare
damithc
reviewed
Jul 17, 2019
| ``` | ||
| </span> | ||
| <span id="output"> | ||
| <popover content="You can select me!" hoverable>This popover's content can be interacted with.</popover> |
There was a problem hiding this comment.
I'm wondering, why can't this be the default/only behavior? Is there any downside to making all popovers hoverable?
There was a problem hiding this comment.
I left a reason here. It is a small problem, but still tolerable enough to make it the only behavior.
|
Doesn't seem to be relevant anymore after MarkBind/vue-strap#115 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Enhancement to an existing feature
Adds docs for MarkBind/vue-strap#114
What is the rationale for this request?
Document the new attribute
hoverableavailable for popovers and tooltips.What changes did you make? (Give an overview)
Added a new entry to the attributes table, and gave an example on how it works.
Provide some example code that this change will affect: