Skip to content
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.

Fix panel max height for older browsers #139

Conversation

ang-zeyu
Copy link

Follow up to #137, for some older browser versions ( tested on edge v44 ) that don't respect max-content - max-height: none achieves the same purpose for the fix

Proposed Commit Message
Fix panel max height for older browsers

Copy link

@marvinchin marvinchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Here is a useful resource for determining browser compatibility: https://caniuse.com/#feat=mdn-css_properties_height_max-content

A vast majority of modern browsers support this, so I don't think this is a critical issue that requires an immediate release. Let's roll this out according to the usual release schedule.

@marvinchin marvinchin added this to the v2.0.1-markbind.40 milestone Mar 30, 2020
@ang-zeyu
Copy link
Author

LGTM :) Here is a useful resource for determining browser compatibility: https://caniuse.com/#feat=mdn-css_properties_height_max-content

A vast majority of modern browsers support this, so I don't think this is a critical issue that requires an immediate release. Let's roll this out according to the usual release schedule.

Thanks for getting to this so quickly again!

Used that as well, didn't realise I was running a very old version of edge haha 😆

Copy link
Member

@yamgent yamgent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ang-zeyu You can merge this too.

@marvinchin marvinchin merged commit 6d2d191 into MarkBind:master Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants