Skip to content
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.

Panel: Go from minimized to expanded on open #23

Merged
merged 1 commit into from
May 17, 2018

Conversation

Chng-Zhi-Xuan
Copy link

What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Enhancement to an existing feature

Resolves MarkBind/markbind#153

What is the rationale for this request?
User would like to save 1 click when viewing content of minimized panels

What changes did you make? (Give an overview)

  • Changed Panel.expanded attribute to true when open is called

Provide a demo

paneldemo

Is there anything you'd like reviewers to focus on?
-NIL-

Testing instructions:

  1. Minimize a panel.
  2. Click on minimized panel, it should expand immediately.

@Chng-Zhi-Xuan Chng-Zhi-Xuan changed the title Modify behavior of open in Panels Modify behavior of 'open' in Panels May 15, 2018
@Chng-Zhi-Xuan
Copy link
Author

Squashed and updated commits

@acjh acjh added this to the v1.1.37-markbind.6 milestone May 15, 2018
@acjh acjh changed the title Modify behavior of 'open' in Panels Panel: Go from minimized to expanded on open May 17, 2018
@acjh acjh merged commit 04e1fd7 into MarkBind:master May 17, 2018
@Chng-Zhi-Xuan Chng-Zhi-Xuan deleted the 153-expand-minimized-panels branch May 27, 2019 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants