Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Step Does Not Validate Modified C0 File #7

Closed
haok1402 opened this issue Oct 6, 2022 · 1 comment
Closed

[Bug Report] Step Does Not Validate Modified C0 File #7

haok1402 opened this issue Oct 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@haok1402
Copy link
Collaborator

haok1402 commented Oct 6, 2022

Describe the bug
After Compile, if we modify the C0 File (even with an invalid one), Step would not raise an error. Step behaves as if the C0 File hasn't been modified. This is unexpected.

To Reproduce

C0VM.mp4

Expected behavior
Ideally, C0VM-ts should detect changes in C0 File before proceeding to Step.

Code being executed
The old C0 File:

int main() {
    int b = 1;
    int c = b + 1;
    return c;
}

The modified C0 File:

int main() {
    int b = 0;
    int main() {
        return b + 1;
    }
    return b;
}
@MarkChenYutian MarkChenYutian added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Oct 7, 2022
MarkChenYutian added a commit that referenced this issue Oct 10, 2022
@MarkChenYutian
Copy link
Owner

Now, if the user edited C0 source code and hit the Step / Run button again, a "Recompile Required" Warning will pop out from and force user to recompile before executing the program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants