-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab rename fix — double click to enter rename mode #28
Conversation
src/components/c0-editor-group.tsx
Outdated
|
||
onChange(e: React.ChangeEvent<HTMLInputElement>) { | ||
e.preventDefault(); | ||
this.setState({title: e.target.value}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that we only setState
when the user has finished editing (a.k.a. stopEditing
is triggered)?
In that case, we will be able to enforce the file extension check (if not ending in .c0
, .c1
, we reject the rename).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, just curious, what is the "wired behavior" of draggable tab when editing file names?
Fixes #16
New issues:
Potential fixes
draggable = "true"
todraggable = "false"
ondiv.ant-tabs-nav-list > div
temporarily while editing tab name.c0
extension in a separate tag wile editingc0
code (probably the way to go since we're now allowingc1
ando0
.