Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to define the playwright-log.txt outputdir when using Browser in python #3203

Closed
Massukio opened this issue Nov 1, 2023 · 3 comments · Fixed by #3210
Closed
Assignees
Labels
enhancement New feature or request priority: medium
Milestone

Comments

@Massukio
Copy link

Massukio commented Nov 1, 2023

Is your feature request related to a problem? Please describe.
When executing robotframework with Browser, I can define the OUTPUTDIR by --outputdir in command line.
However, when executing Brower purely in python, I find no way to set the OUTPUTDIR to where ever I want.

browser = Browser(enable_playwright_debug=True)

Describe the solution you'd like
An API in python side to define the customized output location for browser debug log.

@aaltat
Copy link
Collaborator

aaltat commented Nov 1, 2023

@allcontributors please add @Massukio for ideas

Copy link
Contributor

@aaltat

I've put up a pull request to add @Massukio! 🎉

@aaltat aaltat added enhancement New feature or request priority: medium labels Nov 1, 2023
aaltat added a commit to aaltat/robotframework-playwright that referenced this issue Nov 3, 2023
@aaltat
Copy link
Collaborator

aaltat commented Nov 3, 2023

After the fix, this is possible:

    browser = Browser.Browser()
    assert browser.outputdir == "."
    browser.outputdir = "/foo/bar"
    assert browser.outputdir == "/foo/bar"

@aaltat aaltat added this to the v18.0.0 milestone Nov 3, 2023
aaltat added a commit that referenced this issue Nov 3, 2023
@aaltat aaltat modified the milestones: v17.6.0, v18.0.0 Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants