Handle RF development version as final version #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhirsz
commented
Dec 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 96.40% 96.69% +0.29%
==========================================
Files 37 37
Lines 4565 4515 -50
==========================================
- Hits 4401 4366 -35
+ Misses 164 149 -15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With previous implementation there was problem where some of our tests didn't run at all. For example if we used ">=7" version specifier, RF "7.0a1" didn't match it. I have decided to just drop support for development versions in version specifier and handle those as 'final' versions. Parsed version (the one from RF) can have development suffix (dev1, rc1..) but it will be ignored.