Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uneven-indent rule reporting last comment with invalid indent #730

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

bhirsz
Copy link
Member

@bhirsz bhirsz commented Sep 15, 2022

Fixes #675

@bhirsz bhirsz requested a review from mnojek as a code owner September 15, 2022 12:04
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Base: 96.92% // Head: 96.92% // No change to project coverage 👍

Coverage data is based on head (056e3f5) compared to base (2720f2e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          24       24           
  Lines        3091     3091           
=======================================
  Hits         2996     2996           
  Misses         95       95           
Impacted Files Coverage Δ
robocop/checkers/spacing.py 99.12% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bhirsz bhirsz force-pushed the fix/uneven_indent_last_comment branch from 2a4c1a2 to d00e9e9 Compare September 15, 2022 12:09
mnojek
mnojek previously approved these changes Sep 15, 2022
@bhirsz bhirsz merged commit e88e33d into master Sep 16, 2022
@bhirsz bhirsz deleted the fix/uneven_indent_last_comment branch September 16, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] allow the last comment in a file follow previous indent
3 participants