Skip to content

Commit

Permalink
Revert "[remkop#1297] remove suggestions to use custom factory for no…
Browse files Browse the repository at this point in the history
…n-static inner classes"

This reverts commit d99bfab.
  • Loading branch information
MarkoMackic committed Oct 17, 2021
1 parent e10f8b9 commit 37a613a
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions docs/index.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1312,7 +1312,7 @@ class SetPositionCommand {

See the sections on <<Custom Parameter Processing>> for more details.

CAUTION: Make sure any nested classes are `static`, or picocli will not be able to instantiate them.
CAUTION: Make sure any nested classes are `static`, or picocli will not be able to instantiate them without a <<Custom Factory>>.

=== Handling Invalid Input

Expand Down Expand Up @@ -1441,7 +1441,7 @@ This may also be useful for applications that need a custom type converter but w

Type converters declared with the `converter` attribute need to have a public no-argument constructor to be instantiated, unless a <<Custom Factory>> is installed to instantiate classes.

CAUTION: If your type converter is declared as nested class, make sure you mark this class as `static`, or picocli will not be able to instantiate your nested converter class.
CAUTION: If your type converter is declared as nested class, make sure you mark this class as `static`, or picocli will not be able to instantiate your nested converter class without a <<Custom Factory>>.

=== Arrays, Collections, Maps
NOTE: Starting from picocli 2.0, the `type` attribute is no longer necessary for `Collection` and `Map` fields:
Expand Down Expand Up @@ -4878,7 +4878,7 @@ class ExecParameterConsumer : IParameterConsumer {
}
----

CAUTION: Make sure any nested classes are `static`, or picocli will not be able to instantiate them.
CAUTION: Make sure any nested classes are `static`, or picocli will not be able to instantiate them without a <<Custom Factory>>.

[[IParameterPreprocessor_Parser_Plugin]]
==== `IParameterPreprocessor` Parser Plugin
Expand Down Expand Up @@ -4980,7 +4980,7 @@ class Edit : Runnable {
}
----

CAUTION: Make sure any nested classes are `static`, or picocli will not be able to instantiate them.
CAUTION: Make sure any nested classes are `static`, or picocli will not be able to instantiate them without a <<Custom Factory>>.

With this preprocessor in place the user can now specify his editor of choice (e.g. `--open=idea`). If no editor is given, the default editor is used:

Expand Down Expand Up @@ -10227,7 +10227,7 @@ class Dynamic {

All transformers are called once, after the full command hierarchy is constructed, and before any command line arguments are parsed.

CAUTION: If your model transformer is declared as nested class, make sure you mark this class as `static`, or picocli will not be able to instantiate your transformer class.
CAUTION: If your model transformer is declared as nested class, make sure you mark this class as `static`, or picocli will not be able to instantiate your transformer class without a <<Custom Factory>>.

=== Automatic Parameter Indexes
==== Automatic Indexes
Expand Down

0 comments on commit 37a613a

Please sign in to comment.