Remove mockito and all related features #136
Conversation
|
I have seen that |
| @@ -21,12 +19,9 @@ dependencies { | |||
| testImplementation libs.kotlin_test_jvm | |||
| testImplementation libs.kotlin_test_junit | |||
|
|
|||
|
|
|||
| // TODO: To be removed | |||
There was a problem hiding this comment.
Not sure about this? Is this related only to Mockito and Spek?
|
Thank you for the PR :) I still have to figure out what the right approach is for these big changes, as they will clearly break code. As for Spek, you shouldn't have to worry about it, because it should only be present in backtick tests. I wanted to remove Spek to have all the tests following the same format, as Spek is jvm only. |
|
Hmm, I would propose to have a 1.x branch (and a new release 1.5 soon) with everything this PR removes marked as Ah I see, can I help with the removal of |
|
Converting Spek to kotlin.test is something I would do in a separate PR, because it isn't user facing and can easily be merged now. If you want to go for it, don't hesitate :-) |
|
I've now removed Spek everywhere, so we're getting close :-) |
|
Sorry, totally forgot about this! Is there something remaining to be done? |
|
Hi, as the mocking feature is still used and even improved (there's currently a PR for it), I'm currently rethinking this approach. It might be better to pull it out into its own artifact, so instead of losing the functionality, people can add another artifact and their tests aren't broken |
|
Okay, that sounds like a good option too. |
Since I also suffered from long autocompletion lists (I mainly use mockk), I decided to remove the dependency on Mockito and all related features as outlined in #73.
Thus this would fix #73.
AUTHORSfile, if it wasn't already present.