Added custom printing of strings while Asserting different types #205
Conversation
| @@ -215,5 +215,6 @@ class ComparisonFailedException(val customMessage: String?, val expected: String | |||
| """.trimMargin().trim() | |||
| ) { | |||
| constructor(customMessage: String?, expected: Any?, actual: Any?) | |||
| : this(customMessage, expected?.toString(), actual?.toString()) | |||
| : this(customMessage, if (expected is String) "\"" + expected.toString() + "\"" else expected?.toString(), | |||
| if (actual is String) "\"" + actual.toString() + "\"" else actual?.toString()) | |||
There was a problem hiding this comment.
The expected and actual Strings are being modded the same way, can we pull a function here?
fun quoteIfString(value: Any?) = if (value is String) "\"$value\"" else value?.toString()
Might want to experiment with triple quotes to avoid the need for backslashes to see if that works better.
| try { | ||
| "5" shouldBeEqualTo 5 | ||
| } catch (e: ComparisonFailedException) { | ||
| e.message shouldBeEqualTo "Expected: <5> but was: <\"5\">" |
There was a problem hiding this comment.
Can you remove the extra space after shouldBeEqualTo?
AUTHORS.md
Outdated
| 1. Piotr Bakalarski [@piotrb5e3](https://github.com/piotrb5e3) ([Contributions](https://github.com/MarkusAmshove/Kluent/commits?author=piotrb5e3)) | ||
| 1. Aarthi T [@AarthiT](https://github.com/AarthiT) ([Contributions](https://github.com/MarkusAmshove/Kluent/commits?author=AarthiT)) |
There was a problem hiding this comment.
Can you add an empty line after your entry? That’ll avoid the diff issue for others because it will always show only people's changes 😄
AarthiT
changed the title
|
Hey @MarkusAmshove, this PR looks good to go from my end. Can you help trigger the build and approve the changes? I can't do either of these right now 😞 |
|
@AarthiT: there's 4 failing tests on your PR. Can you have a look when you have a few moments and fix them as necessary? |
|
Has been implemented with #207 |
Description
The AssertionError given when asserting an Integer and a String of the same Integer is not intuitive enough as the error message contains the same value for both expected and actual args.
Example: listOf(1, 2, "fizz", 4, "buzz") shouldEqual listOf("1", "2", "fizz", 4, "buzz") gives the AssertionError as -
java.lang.AssertionError: Expected <[1, 2, fizz, 4, buzz]>, actual <[1, 2, fizz, 4, buzz]>.
The change made to solve this issue was update ComparisonFailedException to take expected and actual args with quotes if they are strings.
This closes the Issue #121 .
Checklist
AUTHORSfile, if it wasn't already present.