[BUG] Marlin on BigTreeTech SKR PRO can't be configured to use the onboard SD-card #14684

eightheads · 2019-07-19T20:36:54Z

Description

Bigtreetech SKR Pro control board(STM32F4) does not seem to hold SD-based EEPROM to the on-board card.

Steps to Reproduce

Load lastest Marlin 2.0 to SKR Pro
Make change via LCD to z-offset, etc, and Save to EEPROM
Power cycle board. Settings have now reverted to initial(firmware) values

Expected behavior: Settings to EEPROM should save between power cycles

Actual behavior: Settings revert to initial firmware values after power cycle
Configs.zip

tpruvot · 2019-07-19T20:39:55Z

if your sdcard is empty (no gcode file) it may cause an issue to save/load the eeprom.dat

tpruvot · 2019-07-19T20:41:49Z

But im not sure the F4/F7 can emulate that on the sdcard, seems a F1 feature

eightheads · 2019-07-19T20:42:08Z

if your sdcard is empty (no gcode file) it may cause an issue to save/load the eeprom.dat

The onboard SD card just has the boards firmware on it. I do not currently have an external SD in my LCD currently.

tpruvot · 2019-07-19T20:44:07Z

on the F4.. its emulated in the SoC flash, not on the SD

dch1921 · 2019-07-20T18:16:29Z

I'm seeing the same issue with the SKR Pro 1.1 Does not save changes to eeprom with M500

LinoBarreca · 2019-07-26T11:06:43Z

why don't you just take the
Marlin/Marlin/src/HAL/HAL_STM32F1/persistent_store_sdcard.cpp which is a F1 platform feature and put it "a level UP" in the /shared features among the SpiEeprom.cpp and I2CEeprom.cpp defining it as VirtualSDEeprom.cpp?

This way you could
#define VIRTUAL_SD_EEPROM 8 (where 8 = 8*512bytes = 4kb user defined eeprom file)
in Configuration.h and use the sdcard instead of a real EEPROM chip on ANY platform/controller which has limited writes before you have to replace the whole board
For platforms which have a real EEPROM chip you can use that OR the virtual eeprom on the SD (user preference).
For platforms which don't have a real EEPROM you would force the define in the platform HAL layer.

And everyone would be happy.

Also...this could allow easy "eeprom" backup/restore from the sdcard: if your printer controller suddenly fails (I.E. a voltage regulator or a burnt IO port on the cpu) or you simply want to do an upgrade of your controller you can replace the board and have the same settings you had before the replacement (z-probe offset, bed mesh, speeds, steps, jerks and so on)

Considering this all, the only reason the user could still choose the "internal eeprom" is if he frequently swaps sd cards.

LinoBarreca · 2019-08-02T10:09:10Z

Apparently someone has done it at the "platform" level.
https://github.com/bigtreetech/BIGTREETECH-SKR-PRO-V1.1/pull/21/files
I wouldn't still merge this into marlin because I still think that EEPROM emulation should be handled at a global level and not at a platform level.

TheWeakBerlin · 2019-09-08T17:24:47Z

Any news on that Topic?

i just bought the SKR PRO Board and it runs well with Marlin 2.0.x i can store Data with M500 on a SD-Card but after shut down the Printer it will not load the Data (Mesh Data for example) but on the SD the eeprom.dat file is still there.

Do i need to implement the "platform level" solution into my version or is there something i missed?

in Configuration.h i set EEPROM_SETTINGS
and at pins_BIGTREE_SKR_PRO_V1.1.h i tried both SRAM_EEPROM_EMULATION and FLASH_EEPROM_EMULATION, with no difference in behavior.

Greetings from Germany :D

EDIT: i just saw the "Platform Level" solution is allready there

tpruvot · 2019-09-08T17:47:05Z

There was a config storage version change last week end.. to V69. When that happens, the SD or FLASH (or whatever) cant be loaded... need a reset

boelle · 2019-09-24T19:11:51Z

@eightheads still having problems?

eightheads · 2019-09-24T19:34:08Z

@eightheads still having problems?

As far as I know this is still an issue in the main Marlin branch.

boelle · 2019-09-24T19:35:13Z

@eightheads have you tested it?

reloxx13 · 2019-09-24T19:38:54Z

still wont load config after restart.

TheWeakBerlin · 2019-09-27T14:47:00Z

I still have Problems too, if i use SRAM_EEPROM_EMULATION i get the version error with V69 of the EEPROM and if i use the FLASH_EEPROM_EMULATION it only loads old data but dont want to store new data.

Evg33 · 2019-10-02T23:16:31Z

#define EEPROM_SETTINGS
#define EEPROM_CHITCHAT       // Give feedback on EEPROM commands. Disable to save PROGMEM.
#define FLASH_EEPROM_EMULATION  // Use Flash-based EEPROM emulation

no problems

dineshvyas · 2019-10-08T16:12:33Z

THIS SHOULD WORK

eightheads · 2019-10-08T16:16:37Z

THIS SHOULD WORK

This would enable Flash based EEPROM emulation, not SD card EEPROM emulation though, correct?

dineshvyas · 2019-10-08T16:23:13Z

THIS SHOULD WORK

This would enable Flash based EEPROM emulation, not SD card EEPROM emulation though, correct?

Correct.

dineshvyas · 2019-10-08T16:31:15Z

I still have Problems too, if i use SRAM_EEPROM_EMULATION i get the version error with V69 of the EEPROM and if i use the FLASH_EEPROM_EMULATION it only loads old data but dont want to store new data.

FLASH_EEPROM_EMULATION is working fine for me, stores new data too.

AnHardt · 2019-10-08T16:51:30Z

The last time i tried EEPROM from SD-card worked.
But only from the external card-reader on the display panel - not from the on-board-slot.
But that's not a fault of the SD-EEPROM emulation but a more general on-board SD problem.

tpruvot · 2019-10-08T17:10:42Z

There was a lot of changes recently on the data storage, we are at v70, but there was other changes in the structure since... each time its reset... Are you sure its not your problem ?

dineshvyas · 2019-10-08T17:47:06Z

SD EEPROM is not supported on STM32F4. it is only supported on STM32F1, so not on SKR PRO V1.1

tpruvot · 2019-10-08T18:02:45Z

some F4 seems to have it, but maybe not the SKR... due to framework differences cf #14808 & #14844

AnHardt · 2019-10-08T18:34:29Z

@dineshvyas
Don't be ridicules. It works on the external SD at SKR PRO 1.1!

dineshvyas · 2019-10-09T11:39:32Z

@dineshvyas
Don't be ridicules. It works on the external SD at SKR PRO 1.1!

I have no such intention to ridicule. i just stated what I read. it was about on board sd card. I am not an expert, I am just looking for a solution. I apologize if by any mean I made you feel bad.

LinoBarreca · 2019-12-10T21:43:39Z

or split it up in multple PR's ?

Yeah that could have been an option but most of those are deeply linked one to the other.
The sdcard bug (this) and the multiple spi (change) are linked. They require a deep change to how marlin handles/defines SPI. This means it has to be backported to the other hals (at least at the interface level)
I am closing the hardware CRC part and I will surely make a PR to "commit it" into the marlin source code. (the hardware CRC wasn't strictly necessary, but since it will require a HAL interface change with the core I preferred to do it now, so I don't ask people to revisit things twice)
As I said somewhere in the above link I need to make that PR because I need help in adapting all the other HALS to the new "variable" spis by board. We need to adapt each pins file (most of them will be a 1 to 1 translation, easy and stupid, because most boards don't have multiple SPIs but just one) and all the hals to handle the new calls. that work is just "adapt this call to fit into what we have now" and it will be easy for the maintainers of the hals once I make the PR. I already did it for the STM32.
Problem isn't that I can't do it myself, I could indeed adapt each pins/hal to the new "dynamic" logic but I will take A LOT to do that if I'm alone. If I push that PR we can have more people working on the "multispi" branch and then merge it all at once.

Today we finished half of the Hardware CRC part. when the other half is ready I'll make the PR.
We are actually working in three (me, @Evg33 and @Patag ) on that one but the problem with board design of the SKR pro makes it harder to work on it because of a (wrong) R5 on the clock line. I sorted the problems out (with their precious testing help) and I guess that by the end of this week we will have the pr done to marlin's source.

jgwinner · 2019-12-11T19:13:04Z

This sounds fantastic. I have an SKR Pro and just started trying to program it. I was going to use UART, not SPI. CR-10, adding another extruder. BLTouch, 2209's and 2208's.

If I can do anything to help, let me know, I'm a long time C++ dev.

    == John ==

Evg33 · 2019-12-20T00:35:47Z

Multiple, simultaneous, SPI buses handling and Smart SD mounting #16260

LinoBarreca · 2019-12-20T16:04:22Z

everyone having this problem, please go and test pr 16260, as linked by @Evg33

boelle · 2019-12-24T12:53:18Z

@eightheads is the issue still the same with all the updates in the last 27 days?

boelle · 2019-12-24T13:31:41Z

btw, who can confirm there is an issue? use the same configs as OP and the same hardware if possible

m-kozlowski · 2019-12-24T14:06:04Z

btw, who can confirm there is an issue?

You mean onboard sd on skr pro? Yes, there is an issue.
It does work with #16260 however.

boelle · 2019-12-24T14:09:22Z

if that is what is in #14684 (comment) then yes

boelle · 2019-12-24T14:10:12Z

@thinkyhead could we get #16260 merged maybe?

LinoBarreca · 2019-12-25T09:15:58Z

16260 is not in a merge-able state yet. We will get there, but it is not yet complete. I will start back working on it after Christmas. Btw merry Christmas everyone.

…

________________________________ From: Bo Herrmannsen <notifications@github.com> Sent: Tuesday, December 24, 2019 3:10:13 PM To: MarlinFirmware/Marlin <Marlin@noreply.github.com> Cc: Lino Barreca <linobarreca@hotmail.com>; Mention <mention@noreply.github.com> Subject: Re: [MarlinFirmware/Marlin] [BUG] Marlin on BigTreeTech SKR PRO can't be configured to use the onboard SD-card (#14684) @thinkyhead<https://github.com/thinkyhead> could we get #16260<#16260> merged maybe? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#14684?email_source=notifications&email_token=AAG3FOZ2POXPL6QMXVJQTD3Q2IJ4LA5CNFSM4IFLWW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHTIHQI#issuecomment-568755137>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAG3FO5DZIYVFIPADHVNZ7LQ2IJ4LANCNFSM4IFLWW6A>.

G-Pereira · 2019-12-25T22:36:52Z

What about printing from the on board SD card @LinoBarreca? I don't want to rush you in any way, I am just wondering if that is possible and planned.
Happy Holidays!

LinoBarreca · 2019-12-25T23:39:00Z

That's actually working on skr pro. It's not merge-able because it needs work on other hals

fighter777 · 2019-12-26T02:49:27Z

good work, i will test that on my board ;)

and i will order a sd card extender ... thx @dineshvyas ^^

G-Pereira · 2019-12-30T16:18:00Z

That's actually working on skr pro. It's not merge-able because it needs work on other hals.

Is it in bugfix-2.0.x? and not in 2.0.x?

LinoBarreca · 2019-12-30T16:38:18Z

That's actually working on skr pro. It's not merge-able because it needs work on other hals.

Is it in bugfix-2.0.x? and not in 2.0.x?

Yes, actually 2.0 is out. This could go into 2.0-bugfix or 2.1-dev (I think the latter is more appropriate since the entity of changes, but there no one could use it)

fighter777 · 2019-12-31T18:40:57Z

that work for me

thank @LinoBarreca

USB port work ?

jgwinner · 2019-12-31T18:58:53Z

I'm away from my machine now, but I wasn't able to get the RepRap SD card working on the SKR Pro 1.1 nor the onboard SD card. The onboard one wasn't recognized. I also was never able to get the USB working.

I was using the Lino7 branch.

I get CRC errors on the display SD card, although it reads the directory fine.

Are there some settings that maybe I was missing?

I have an ST Link coming, I can run further diagnostics if you need.

== John ==

LinoBarreca · 2019-12-31T19:20:42Z

that work for me

thank @LinoBarreca

USB port work ?

Not yet. That's another hardware part...I might work on it when that will be merged. But it's unlikely since that pr opens a million of possibilities for developing more useful things.

LinoBarreca · 2019-12-31T19:22:55Z

@jgwinner as I said on the PR pull it again and test it again. When @thinkyhead did the forced push something broke. I did a force push again from my last knowing one and it's working now, for sure.

jgwinner · 2019-12-31T20:27:31Z

@LinoBarreca Oh, sorry, Missed that (bandwidth constrained ATM).

I will do that!

boelle · 2020-01-07T00:54:45Z

since we have not heard from OP i will mark this one as stale

Lack of Activity
This issue is being closed due to lack of activity. If you have solved the
issue, please let us know how you solved it. If you haven't, please tell us
what else you've tried in the meantime, and possibly this issue will be
reopened.

jgwinner · 2020-01-07T01:33:19Z

Six days stale over Christmas and New Years gets it closed? Good grief.

LinoBarreca · 2020-01-07T08:28:16Z

there's a fix anyway for it...so it makes sense to be closed.

fighter777 · 2020-01-07T08:46:56Z

fix not merged ?

LinoBarreca · 2020-01-07T08:50:23Z

not yet. it needs work on other boards... but on skr-pro it works.

github-actions · 2020-07-03T13:03:37Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

boelle changed the title ~~SD-EEPROM not with Bigtreetech SKR Pro(STM32F4) on-board SD card?~~ [BUG] SD-EEPROM not with Bigtreetech SKR Pro(STM32F4) on-board SD card? Jul 21, 2019

boelle added the Bug: Potential ? label Jul 21, 2019

boelle removed the Bug: Potential ? label Aug 28, 2019

reloxx13 mentioned this issue Sep 9, 2019

Use Flash-based EEPROM on SKR mini-E3 #15126

Merged

reloxx13 added a commit to reloxx13/Marlin that referenced this issue Oct 4, 2019

disable bugged eeprom emulation MarlinFirmware#14684

7b0ab64

InsanityAutomation mentioned this issue Dec 10, 2019

Added support for SKR Pro V1.1 InsanityAutomation/Marlin#76

Merged

boelle closed this as completed Jan 7, 2020

LinoBarreca mentioned this issue Jan 7, 2020

Multiple, simultaneous, SPI buses handling and Smart SD mounting #16260

Closed

6 tasks

github-actions bot locked and limited conversation to collaborators Jul 3, 2020

[BUG] Marlin on BigTreeTech SKR PRO can't be configured to use the onboard SD-card #14684

[BUG] Marlin on BigTreeTech SKR PRO can't be configured to use the onboard SD-card #14684

Comments

eightheads commented Jul 19, 2019

Description

Steps to Reproduce

tpruvot commented Jul 19, 2019 • edited

tpruvot commented Jul 19, 2019

eightheads commented Jul 19, 2019 • edited

tpruvot commented Jul 19, 2019

dch1921 commented Jul 20, 2019

LinoBarreca commented Jul 26, 2019 • edited

LinoBarreca commented Aug 2, 2019

TheWeakBerlin commented Sep 8, 2019 • edited

tpruvot commented Sep 8, 2019

boelle commented Sep 24, 2019

eightheads commented Sep 24, 2019

boelle commented Sep 24, 2019

reloxx13 commented Sep 24, 2019

TheWeakBerlin commented Sep 27, 2019

Evg33 commented Oct 2, 2019 • edited

dineshvyas commented Oct 8, 2019

eightheads commented Oct 8, 2019 • edited by thinkyhead

dineshvyas commented Oct 8, 2019 • edited by thinkyhead

dineshvyas commented Oct 8, 2019

AnHardt commented Oct 8, 2019

tpruvot commented Oct 8, 2019

dineshvyas commented Oct 8, 2019

tpruvot commented Oct 8, 2019

AnHardt commented Oct 8, 2019

dineshvyas commented Oct 9, 2019

LinoBarreca commented Dec 10, 2019 • edited

jgwinner commented Dec 11, 2019

Evg33 commented Dec 20, 2019 • edited

LinoBarreca commented Dec 20, 2019

boelle commented Dec 24, 2019

boelle commented Dec 24, 2019

m-kozlowski commented Dec 24, 2019

boelle commented Dec 24, 2019

boelle commented Dec 24, 2019

LinoBarreca commented Dec 25, 2019 via email

G-Pereira commented Dec 25, 2019

LinoBarreca commented Dec 25, 2019 via email • edited

fighter777 commented Dec 26, 2019

G-Pereira commented Dec 30, 2019 • edited

LinoBarreca commented Dec 30, 2019

fighter777 commented Dec 31, 2019

jgwinner commented Dec 31, 2019

LinoBarreca commented Dec 31, 2019

LinoBarreca commented Dec 31, 2019

jgwinner commented Dec 31, 2019

boelle commented Jan 7, 2020

jgwinner commented Jan 7, 2020

LinoBarreca commented Jan 7, 2020

fighter777 commented Jan 7, 2020

LinoBarreca commented Jan 7, 2020

github-actions bot commented Jul 3, 2020

tpruvot commented Jul 19, 2019 •

edited

eightheads commented Jul 19, 2019 •

edited

LinoBarreca commented Jul 26, 2019 •

edited

TheWeakBerlin commented Sep 8, 2019 •

edited

Evg33 commented Oct 2, 2019 •

edited

eightheads commented Oct 8, 2019 •

edited by thinkyhead

dineshvyas commented Oct 8, 2019 •

edited by thinkyhead

LinoBarreca commented Dec 10, 2019 •

edited

Evg33 commented Dec 20, 2019 •

edited

LinoBarreca commented Dec 25, 2019 via email •

edited

G-Pereira commented Dec 30, 2019 •

edited