Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z_RAISE_BEFORE_HOMING / G28 / G28XY #1550

Closed
woodsmoke opened this issue Mar 2, 2015 · 8 comments
Closed

Z_RAISE_BEFORE_HOMING / G28 / G28XY #1550

woodsmoke opened this issue Mar 2, 2015 · 8 comments

Comments

@woodsmoke
Copy link

Core XY printer, Marlin development downloaded 02/03/15. Arduino 1.05

define Z_RAISE_BEFORE_HOMING 4

Start Printer, G28 (or) G28XY. Neither command raises the Z before homing.

See #1549 for Marlin config.

@thinkyhead
Copy link
Member

Try adding these lines immediately after line 1638 (#if defined (Z_RAISE_BEFORE_HOMING) && (Z_RAISE_BEFORE_HOMING > 0)) and see if it makes any difference....

current_position[Z_AXIS] = 0;
plan_set_position(current_position[X_AXIS], current_position[Y_AXIS], current_position[Z_AXIS], current_position[E_AXIS]);

@thinkyhead
Copy link
Member

Hmm, well never mind! That change won't matter if you have Z_SAFE_HOMING enabled.

@thinkyhead
Copy link
Member

So... You should print out some messages to the serial out at the point where it might be failing, and see what's going on. Insert some statements like the following between lines 1648-1660 and then try G28 to see how it behaves....

  SERIAL_ECHO_START;
  SERIAL_ECHOPAIR("z dest:", destination[Z_AXIS]);
  SERIAL_ECHOLN("");

@thinkyhead
Copy link
Member

From what I can see, this routine has never been programmed to raise the Z before homing with G28 XY. Only homing commands that include Z (G28, G28 Z, G28 XZ, G28 YZ, and G28 XYZ) are programmed to invoke Z_RAISE_BEFORE_HOMING, and only G28 and G28 XYZ are programmed to invoke it without first having homed X and Y to a known position (setting the axis_known_position flags).

@woodsmoke
Copy link
Author

I'll begin my adventures in coding forthwith

@boelle
Copy link
Contributor

boelle commented Mar 10, 2015

is this related to #1553 ?

@woodsmoke
Copy link
Author

It works now

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants