Allow from 0 to 5 preheat setups (bugfix)

[GMagician]

• this will complete the "more than 2" preheats setup integration
• added possibility to have 0 or 1 preheats setup (freeing up memory)

Fix also #18450

[thinkyhead]

Before this is merged, I suppose it would be good to get rid of the need to define so many preheat strings in the language files, and use substitution instead. The simplest substitution would be to use S_FMT which works with the printf functions. Alternatively, custom substitution with an extension to the menu items could also work, via lcd_put_u8str_ind_P.

The thing is, in future I want users to be able to choose the name of each preset from a larger list of 10 or more materials. So, these fixed language strings will need to be replaced to support that added flexibility anyway.

[GMagician]

The simplest substitution would be to use S_FMT which works with the printf functions. Alternatively, custom substitution with an extension to the menu items could also work, via lcd_put_u8str_ind_P.

I'll check how to manage this.

[GMagician]

I suppose it would be good to get rid of the need to define so many preheat strings

I checked how menu items work and nothing is ready to accept a dynamic string then I think some sort of new ACTION_ITEM must be created...something ACTION_ITEM_FMT? or completely wrong direction?

[thinkyhead]

I'll check how to manage this.

There is currently a set of menu item macros which take an index (e.g., MENU_ITEM_N_P). This index value (MenuItemBase::itemIndex) is then passed on to lcd_put_u8str_ind_P to display a number with an optional "E" prefix. The ~ and * characters are used for these substitutions. I propose to add another substitution character "$" and another optional parameter taking a pointer to a list of PSTR pointers (which itself may be stored in PROGMEM). When $ is seen, the index value from the menu item can be used as a lookup into the list of PSTR pointers, and the string from the list substituted in place.

So, it means extending MenuItemBase with a static pointer to a list of strings (or a general-use void pointer) to be used for this kind of extension. The pointer could be used in some instances for a single string substitution, or to point to some other data that the menu item will use for display.

[thinkyhead]

I just did a test with the code in its current state, and it worked well for me. I think this can be merged for further mayhem testing and exercise.

[thisiskeithb]

@thinkyhead: The only issue I found was with 2004/character LCDs displaying a percent symbol after the right arrow (looks fine on a 12864/full graphic LCD). I dug through the related code and couldn't find an obvious reason for it:

Fixed in #18644

[GMagician]

it seems writing 1 char less. In my display '>' is on last column

[thisiskeithb]

it seems writing 1 char less. In my display '>' is on last column

Which LCD do you have? It looks fine with a 12864/full graphic controller:

[thisiskeithb]

It repeats the last character from the menu item above it on the 2004 LCDs. Here's a photo from the Configuration menu:

Fixed in #18644

[GMagician]

Which LCD do you have? It looks fine with a 12864/full graphic controller:

Yes this is what I have

[thisiskeithb]

Yes this is what I have

I dug through the code, but couldn't find an obvious reason for the error on 2004/character LCDs. Have any ideas?

[GMagician]

Something has been changed on the for cycle, but this shouldn't "repeat" last char of previous line

[thinkyhead]

Something has been changed on the for cycle, but this shouldn't "repeat" last char of previous line

It's just not writing over it as it scrolls (or writing over the contents of the previous screen).