Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "#define Y2_DRIVER_TYPE xxxx" but "Y2_SPEP_PIN" does not work in 2.1.2.2 #26801

Closed
1 task done
SeanW2024 opened this issue Feb 18, 2024 · 4 comments
Closed
1 task done
Labels
Bug: Confirmed ! Fix Included A fix is included in the description

Comments

@SeanW2024
Copy link

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

V2.1.2&V2.1.2.1 works well.In version 2.1.2.2, the corresponding pins did not generate pulse signals.In fact, if E1_STEP_PIN is defined in pin. h, when # define X2-DRIVER-TYPE A4988, compilation will prompt "Note: Auto assigned X2 STEP/DIR/ENABLE-PINs to unused En_STEP/DIR/ENABLE-PINs." However, when # define Y2-DRIVER-TYPE A4988,the compiler will not provide any prompts.

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

2.1.2.2

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

@ellensp
Copy link
Contributor

ellensp commented Feb 18, 2024

In bugfix HAS_DUAL_Y_STEPPERS was removed from the code

but 2.1.2.2 still uses it, but setting this define was omitted from the 2.1.2.2 code

open up Marlin/src/inc/Conditionals_LCD.h

Find

#ifdef Y2_DRIVER_TYPE
  #define HAS_Y2_STEPPER 1
#endif

replace it with

#ifdef Y2_DRIVER_TYPE
  #define HAS_Y2_STEPPER 1
  #define HAS_DUAL_Y_STEPPERS 1
#endif

This brings back the warning and from scanning the code should make it work again

@SeanW2024
Copy link
Author

SeanW2024 commented Feb 19, 2024 via email

@ellensp ellensp added the Fix Included A fix is included in the description label Feb 27, 2024
@thisiskeithb thisiskeithb changed the title "#define Y2_DRIVER_TYPE xxxx" but "Y2_SPEP_PIN" not work [BUG] "#define Y2_DRIVER_TYPE xxxx" but "Y2_SPEP_PIN" does not work in 2.1.2.2 Mar 1, 2024
@thisiskeithb
Copy link
Member

Closing since this is already fixed in bugfix-2.1.x.

@thisiskeithb
Copy link
Member

Patch for 2.1.x submitted:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Confirmed ! Fix Included A fix is included in the description
Projects
None yet
Development

No branches or pull requests

3 participants