[BUG] Broken env_validate.h check for BTT Octopus Pro V1

[FREAKASAS]

Compilation fails. Using the old Octopus Pro 1.0 definitions results in an STM32F4 error, and using the Octopus Pro Max EZ definitions compiles but crashes the firmware.

You don't reuse any of the Octopus Pro 1.0 / STM32F4 definitions with the referenced PR.

Use the files from the PR's source fork (.ZIP download) or wait until it is merged.

Using a minimal config, this compiles fine.

Minimal Config:

diff --git a/Marlin/Configuration.h b/Marlin/Configuration.h
index b21eba7..2c7199f 100644
--- a/Marlin/Configuration.h
+++ b/Marlin/Configuration.h
@@ -67,7 +67,7 @@
 
 // Choose the name from boards.h that matches your setup
 #ifndef MOTHERBOARD
-  #define MOTHERBOARD BOARD_RAMPS_14_EFB
+  #define MOTHERBOARD BOARD_BTT_OCTOPUS_PRO_V1_1
 #endif
 
 /**
@@ -78,7 +78,7 @@
  *
  * :[-1, 0, 1, 2, 3, 4, 5, 6, 7]
  */
-#define SERIAL_PORT 0
+#define SERIAL_PORT -1
 
 /**
  * Serial Port Baud Rate
diff --git a/platformio.ini b/platformio.ini
index e3bdb6f..f54fee7 100644
--- a/platformio.ini
+++ b/platformio.ini
@@ -13,7 +13,7 @@
 [platformio]
 src_dir      = Marlin
 boards_dir   = buildroot/share/PlatformIO/boards
-default_envs = mega2560
+default_envs = STM32H723ZE_btt
 include_dir  = Marlin
 extra_configs =
     Marlin/config.ini

Compile log using the above minimal config:

STM32H723ZE_btt SUCCESS:

Archiving .pio/build/STM32H723ZE_btt/libFrameworkArduino.a
Indexing .pio/build/STM32H723ZE_btt/libFrameworkArduino.a
Linking .pio/build/STM32H723ZE_btt/firmware.elf
Checking size .pio/build/STM32H723ZE_btt/firmware.elf
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [          ]   2.0% (used 11544 bytes from 577536 bytes)
Flash: [==        ]  20.0% (used 104916 bytes from 524288 bytes)
Building .pio/build/STM32H723ZE_btt/firmware.bin
====================================== [SUCCESS] Took 40.74 seconds ======================================

Environment      Status    Duration
---------------  --------  ------------
STM32H723ZE_btt  SUCCESS   00:00:40.735
======================================= 1 succeeded in 00:00:40.735 =======================================
 *  Terminal will be reused by tasks, press any key to close it. 

Originally posted by @thisiskeithb in #26044 (comment)

[ellensp]

@FREAKASAS Please check your issue, most links do not work and it is rather incomprehensible

Also please use the issue template when creating issues, By using https://github.com/MarlinFirmware/Marlin/issues/new/choose.
What ever interface you used (which may be whats app related) Made a mess of things

Desperately trying to read between the lines...

Building with #define MOTHERBOARD BOARD_BTT_OCTOPUS_PRO_V1_0

This has 5 different build environments.

✅ STM32F446ZE_btt
✅ STM32F446ZE_btt_usb_flash_drive
✅STM32F429ZG_btt
✅STM32F429ZG_btt_usb_flash_drive
❌STM32H723ZE_btt

4 build fine but STM32H723ZE_btt results in #error "Oops! Select an STM32F4 board in 'Tools > Board.'"

Marlin/src/pins/stm32f4/pins_BTT_OCTOPUS_V1_common.h needs updated

#include "env_validate.h"

becomes

#if NOT_TARGET(STM32H7)
  #include "env_validate.h"
#else
  #include "../stm32h7/env_validate.h"
#endif

To allow for the STM32H7 Variant.

I cannot test any STM32H723 based board as I don't have access to any.

[thisiskeithb]

Fixed in #26831

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.