馃┕ Fix MCU check for STM32H7-based BTT Octopus Pro V1 #26831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisiskeithb
force-pushed
the
pr/fix_octopus_env_check
branch
from
0297868
to
73361b8
Compare
thisiskeithb
changed the title
Co-authored-by: ellensp <530024+ellensp@users.noreply.github.com>
thisiskeithb
force-pushed
the
pr/fix_octopus_env_check
branch
from
73361b8
to
3fd850e
Compare
sjasonsmith
reviewed
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to our use of DRY in the pins files, there needs to be an additional target check in
pins_BTT_OCTOPUS_V1_common.hfor theenv_validate.hinclude since Octopus Pro V1 ships with both STM32F4 & STM32H7 MCUs.Note: I tried another method by removing the
env_validate.hincludes in both the Octopus board common files and defining them in individual pins files, but there are still nested pin includes that that end up failing due to mismatched MCUs.Requirements
STM32H7-based BTT Octopus Pro V1
Benefits
STM32H7-based BTT Octopus Pro V1 configs will build
Related Issues