SHOW_CUSTOM_BOOTSCREEN hides Marlin logo

[AnHardt]

The current code (and also the state before this patches #8181 #8182) is far from what we wanted when we introduced SHOW_CUSTOM_BOOTSCREEN. We wanted an additional logo - not a replacement of the Marlin logo.
In the time before the bitmap of the Marlin logo was simply replaced. Only the replaced logo was shown.
To emphasise: "This is Marlin", we wanted to provide a simple way to show a additional custom logo without not showing the Marlin logo.

If that is not wanted anymore, please remove the option for SHOW_CUSTOM_BOOTSCREEN and go back to replacing the picture. We don't want to make it too easy to hide - "This is Marlin".

Ps:
The additional delay during the boot and the additional use of memory was a wanted penalty for using a custom logo.

[thinkyhead]

It got broken? See if this helps:

  #if ENABLED(SHOW_BOOTSCREEN)
    #if ENABLED(DOGLCD)                           // On DOGM the first bootscreen is already drawn
      #if ENABLED(SHOW_CUSTOM_BOOTSCREEN)
        safe_delay(CUSTOM_BOOTSCREEN_TIMEOUT);    // Custom boot screen pause
        lcd_bootscreen();                         // Show Marlin boot screen
      #endif
-     safe_delay(BOOTSCREEN_TIMEOUT);             // Pause
-   #elif ENABLED(ULTRA_LCD)
+   #endif
+   safe_delay(BOOTSCREEN_TIMEOUT);               // Pause
+   #if ENABLED(ULTRA_LCD)
      lcd_bootscreen();
      #if DISABLED(SDSUPPORT)
        lcd_init();
      #endif
    #endif
  #endif

[Tannoo]

This is what I have with 2.0.x and it works just fine on AVR:

  #if ENABLED(SHOW_BOOTSCREEN)
    #if ENABLED(DOGLCD)                           // On DOGM the first bootscreen is already drawn
      #if ENABLED(SHOW_CUSTOM_BOOTSCREEN)
        safe_delay(CUSTOM_BOOTSCREEN_TIMEOUT);    // Custom boot screen pause
        lcd_bootscreen();                         // Show Marlin boot screen
      #endif
      safe_delay(BOOTSCREEN_TIMEOUT);             // Pause
    #elif ENABLED(ULTRA_LCD)
      lcd_bootscreen();
      #if DISABLED(SDSUPPORT)
        lcd_init();
      #endif
    #endif
  #endif

[thinkyhead]

Sounds like something may be amiss with your configuration @AnHardt but I will double-check when I get to the office where we have a CR-10 with graphical display.

[AnHardt]

Sorry. Was misleaded by
https://github.com/thinkyhead/Marlin/blob/a516856df953667c30742f5517f6d052b10030eb/Marlin/src/lcd/ultralcd_impl_DOGM.h#L355-L363

[fred2088]

https://www.youtube.com/watch?v=HMwmDu2FBQc
still got the same result with bugfix 1.1.x on 26/11/2017

Regards

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.