Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LPC176x] Update PIO extrascript #12878

Merged
merged 2 commits into from Jan 12, 2019

Conversation

p3p
Copy link
Member

@p3p p3p commented Jan 11, 2019

Description

Update the LPC176x platforms upload drive finding extrascript to exit gracefully on error, allowing the build to continue normally. The old method used to detect whether it was an upload target or just a build did not work so the script will always try to locate a drive, there is probably a way to detect the running build target but I didn't see it.

As an extra the platformio.ini is updated to assign names to the downloaded zip libraries, rather than leaving it as the downloaded filename.
DUE doesn't like libraries with names, don't have time to argue with it.

Related Issues

#12877

@@ -161,7 +161,7 @@ src_filter = ${common.default_src_filter} +<src/HAL/HAL_LPC1768>
monitor_speed = 250000
lib_deps = Servo
LiquidCrystal
https://github.com/MarlinFirmware/U8glib-HAL/archive/dev.zip
U8glib-HAL=https://github.com/MarlinFirmware/U8glib-HAL/archive/dev.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful syntax. May be helpful in other places too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too, I added it to all the downloaded zip libs to clean things up in the first commit, but DUE builds failed for errors with no apparent cause so reverted it.

@thinkyhead thinkyhead merged commit 2919f30 into MarlinFirmware:bugfix-2.0.x Jan 12, 2019
@p3p p3p deleted the pr_update_extrascript branch March 1, 2019 21:01
@Bob-the-Kuhn
Copy link
Contributor

Bob-the-Kuhn commented Apr 1, 2019 via email

@Ofr3d
Copy link

Ofr3d commented Apr 1, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants