New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LPC176x] Update PIO extrascript #12878
[LPC176x] Update PIO extrascript #12878
Conversation
@@ -161,7 +161,7 @@ src_filter = ${common.default_src_filter} +<src/HAL/HAL_LPC1768> | |||
monitor_speed = 250000 | |||
lib_deps = Servo | |||
LiquidCrystal | |||
https://github.com/MarlinFirmware/U8glib-HAL/archive/dev.zip | |||
U8glib-HAL=https://github.com/MarlinFirmware/U8glib-HAL/archive/dev.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a useful syntax. May be helpful in other places too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so too, I added it to all the downloaded zip libs to clean things up in the first commit, but DUE builds failed for errors with no apparent cause so reverted it.
I just compiled a bare bone LPC1768 config with no problems.
Please post your config files & I’ll try to compile with them.
I couldn’t find this post. You may want to open a new issue to be sure the files can be easily accessed.
Bob
From: Ofr3d [mailto:notifications@github.com]
Sent: Monday, April 1, 2019 4:31 AM
To: MarlinFirmware/Marlin
Cc: Subscribed
Subject: Re: [MarlinFirmware/Marlin] [LPC176x] Update PIO extrascript (#12878)
I'm still stuck with an error, tried deleting update_script but got the same results..
what can I do to get around it?
<https://user-images.githubusercontent.com/47714572/55317711-be2e6b80-5479-11e9-884c-16504860e6ad.png> LPC1768 ERROR
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#12878 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ATu-Z7c1Bf06WmPYFBQC3Zj1tnjbbRWoks5vcdHwgaJpZM4Z8LsV> . <https://github.com/notifications/beacon/ATu-Z6yyeE5cCCIaELQeqbcly6R-cI6qks5vcdHwgaJpZM4Z8LsV.gif>
|
Hi Bob,
To my embarrassment I was trying to build with LPC1768 for MKS GEN L
instead of the atmega 2560 ..
Thank you very much for your offering
בתאריך יום ב׳, 1 באפר׳ 2019, 17:26, מאת Bob Kuhn <notifications@github.com
…:
I just compiled a bare bone LPC1768 config with no problems.
Please post your config files & I’ll try to compile with them.
I couldn’t find this post. You may want to open a new issue to be sure the
files can be easily accessed.
Bob
From: Ofr3d ***@***.***
Sent: Monday, April 1, 2019 4:31 AM
To: MarlinFirmware/Marlin
Cc: Subscribed
Subject: Re: [MarlinFirmware/Marlin] [LPC176x] Update PIO extrascript
(#12878)
I'm still stuck with an error, tried deleting update_script but got the
same results..
what can I do to get around it?
<
https://user-images.githubusercontent.com/47714572/55317711-be2e6b80-5479-11e9-884c-16504860e6ad.png>
LPC1768 ERROR
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <
#12878 (comment)>
, or mute the thread <
https://github.com/notifications/unsubscribe-auth/ATu-Z7c1Bf06WmPYFBQC3Zj1tnjbbRWoks5vcdHwgaJpZM4Z8LsV>
. <
https://github.com/notifications/beacon/ATu-Z6yyeE5cCCIaELQeqbcly6R-cI6qks5vcdHwgaJpZM4Z8LsV.gif>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#12878 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AtgRDOsA4muxXS4yY6mFdaqqxjZGRYP5ks5vchcMgaJpZM4Z8LsV>
.
|
Description
Update the LPC176x platforms upload drive finding extrascript to exit gracefully on error, allowing the build to continue normally. The old method used to detect whether it was an upload target or just a build did not work so the script will always try to locate a drive, there is probably a way to detect the running build target but I didn't see it.
As an extra the platformio.ini is updated to assign names to the downloaded zip libraries, rather than leaving it as the downloaded filename.DUE doesn't like libraries with names, don't have time to argue with it.
Related Issues
#12877